New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7246: ClassCastException when opening heap dump #243
Conversation
Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
Hi @tobiasstadler, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobiasstadler" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
@tobiasstadler This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@tobiasstadler |
Thank you for the contribution @tobiasstadler! :) |
/sponsor |
@thegreystone @tobiasstadler Pushed as commit 917a95c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Signed-off-by: Tobias Stadler ts.stadler@gmx.de
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/243/head:pull/243
$ git checkout pull/243
Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.java.net/jmc pull/243/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 243
View PR using the GUI difftool:
$ git pr show -t 243
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/243.diff